feat: finish routing

This commit is contained in:
Mark Bailey 2025-09-06 17:56:59 -04:00
parent 4c6e0c9ffb
commit a8e8a97e85
7 changed files with 197 additions and 71 deletions

View File

@ -5,17 +5,13 @@ import (
"net/http" "net/http"
) )
type HandlerFn func(w http.ResponseWriter, r *http.Request) error type (
HandlerFn func(w http.ResponseWriter, r *http.Request) error
MiddlewareFn func(HandlerFn) HandlerFn
)
func (h HandlerFn) ServeHTTP(w http.ResponseWriter, r *http.Request) { func (h HandlerFn) ServeHTTP(w http.ResponseWriter, r *http.Request) {
if err := h(w, r); err != nil { if err := h(w, r); err != nil {
http.Error(w, fmt.Sprintf(`An internal error has occurred: %s`, err), http.StatusInternalServerError) http.Error(w, fmt.Sprintf(`An internal error has occurred: %s`, err), http.StatusInternalServerError)
return
}
}
func (h HandlerFn) ToHandlerFunc() http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
h.ServeHTTP(w, r)
} }
} }

View File

@ -7,13 +7,16 @@ import (
type Storer interface { type Storer interface {
Close() error Close() error
Delete(context.Context, string) error Delete(ctx context.Context, key string) error
Get(context.Context, string) ([]byte, error) Get(ctx context.Context, key string) ([]byte, error)
Put(context.Context, string, []byte, time.Duration) error GetForPrefix(ctx context.Context, prefix string) (map[string][]byte, error)
Put(ctx context.Context, key string, val []byte, ttl time.Duration) error
} }
type RouteCacher interface { type RouteCacher interface {
Add(string, string) error Add(name string, path string) error
GetPath(string) (string, error) AddRouteInfo(routeInfo RouteInfo) error
GetPath(name string) (string, error)
GetRouteInfo(name string) (RouteInfo, error)
All() (map[string]string, error) All() (map[string]string, error)
} }

View File

@ -51,6 +51,48 @@ func (b *badgerStore) Put(ctx context.Context, key string, val []byte, ttl time.
} }
} }
func (b *badgerStore) GetForPrefix(ctx context.Context, prefix string) (map[string][]byte, error) {
done := make(chan struct {
val map[string][]byte
err error
}, 1)
go func() {
valCopy := make(map[string][]byte)
err := b.db.View(func(txn *badger.Txn) error {
it := txn.NewIterator(badger.DefaultIteratorOptions)
defer it.Close()
prefix := []byte(prefix)
for it.Seek(prefix); it.ValidForPrefix(prefix); it.Next() {
item := it.Item()
k := item.Key()
err := item.Value(func(v []byte) error {
valCopy[string(k)] = v
return nil
})
if err != nil {
done <- struct {
val map[string][]byte
err error
}{make(map[string][]byte), err}
}
}
return nil
})
done <- struct {
val map[string][]byte
err error
}{valCopy, err}
}()
select {
case <-ctx.Done():
return nil, ctx.Err()
case res := <-done:
return res.val, nil
}
}
func (b *badgerStore) Get(ctx context.Context, key string) ([]byte, error) { func (b *badgerStore) Get(ctx context.Context, key string) ([]byte, error) {
done := make(chan struct { done := make(chan struct {
val []byte val []byte

View File

@ -6,7 +6,11 @@ import (
"path/filepath" "path/filepath"
) )
var ErrCacheUninitialized = errors.New("the route cache is uninitialized") var (
ErrCacheUninitialized = errors.New("the route cache is uninitialized")
ErrFailedToCreateRouteCache = errors.New("failed to create route cache")
ErrRouterNotCreated = errors.New("router not created")
)
type ErrRouteNotFound struct { type ErrRouteNotFound struct {
route string route string

View File

@ -2,8 +2,8 @@ package joist
import ( import (
"context" "context"
"regexp" "errors"
"strings" "log"
"sync" "sync"
"time" "time"
@ -11,10 +11,9 @@ import (
jerr "git.markbailey.dev/cerbervs/joist/internal/errors" jerr "git.markbailey.dev/cerbervs/joist/internal/errors"
) )
const suff = "route_cache"
type routeCache struct { type routeCache struct {
rs map[string]string rs map[string]string
ris map[string]*RouteInfo
s Storer s Storer
ttl time.Duration ttl time.Duration
} }
@ -22,9 +21,8 @@ type routeCache struct {
type RouteCacheOpt func(*routeCache) type RouteCacheOpt func(*routeCache)
var ( var (
rcLock sync.Mutex
rcOnce sync.Once rcOnce sync.Once
c *routeCache cache *routeCache
) )
func WithTTL(ttl time.Duration) RouteCacheOpt { func WithTTL(ttl time.Duration) RouteCacheOpt {
@ -39,22 +37,21 @@ func WithStore(store Storer) RouteCacheOpt {
} }
} }
func NewRouteCache(opts ...RouteCacheOpt) (*routeCache, error) { func NewRouteCacheService(opts ...RouteCacheOpt) (*routeCache, error) {
s, err := badger.NewBadgerStore(badger.WithSubDir("route_cache")) rcOnce.Do(func() {
if err != nil { c, err := newRouteCache(opts...)
return nil, jerr.Wrap(jerr.ErrCacheUninitialized, err) if err != nil {
log.Fatal(err)
}
cache = c
})
if cache == nil {
return nil, jerr.ErrCacheUninitialized
} }
c = &routeCache{ return cache, nil
rs: make(map[string]string),
s: s,
}
for _, opt := range opts {
opt(c)
}
return c, nil
} }
func (r *routeCache) All() (map[string]string, error) { func (r *routeCache) All() (map[string]string, error) {
@ -74,6 +71,8 @@ func (r *routeCache) Add(name string, path string) error {
return err return err
} }
r.rs[name] = path
return nil return nil
} }
@ -82,32 +81,70 @@ func (r *routeCache) GetPath(name string) (string, error) {
return path, nil return path, nil
} }
return string(""), jerr.NewErrRouteNotFound(string(name)) if path, err := r.s.Get(context.Background(), name); err == nil {
} return string(path), nil
func (r *routeCache) GetDescription(name string) (string, error) {
// TODO: implement
return "", nil
}
func convertRouteToRouteName(route string) (string, error) {
name := "app"
if route == "/" {
return name + ".home", nil
} }
route = strings.ReplaceAll(route, "/", ".") return "", errors.New("route not found in cache")
route = strings.ReplaceAll(route, "-", "_") }
paramRegex := regexp.MustCompile(`\.{[^}]*}`) func (r *routeCache) AddRouteInfo(routeInfo RouteInfo) error {
params := paramRegex.FindAllString(route, -1) ttl := r.ttl
route = paramRegex.ReplaceAllString(route, "") if ttl == 0 {
ttl = 1 * time.Hour
if len(params) > 0 {
route += ".params"
} }
name += strings.TrimRight(route, ".") if err := r.s.Put(context.Background(), routeInfo.Name+":method", []byte(routeInfo.Method), ttl); err != nil {
return err
}
if err := r.s.Put(context.Background(), routeInfo.Name+":path", []byte(routeInfo.Path), ttl); err != nil {
return err
}
if err := r.s.Put(context.Background(), routeInfo.Name+":description", []byte(routeInfo.Description), ttl); err != nil {
return err
}
if err := r.s.Put(context.Background(), routeInfo.Name+":title", []byte(routeInfo.Title), ttl); err != nil {
return err
}
return name, nil r.rs[routeInfo.Name] = routeInfo.Path
r.ris[routeInfo.Name] = &routeInfo
return nil
}
func (r *routeCache) GetRouteInfo(name string) (RouteInfo, error) {
if ri, ok := r.ris[name]; ok {
return *ri, nil
}
if info, err := r.s.GetForPrefix(context.Background(), name); err == nil {
return RouteInfo{
Method: string(info[":method"]),
Name: name,
Path: string(info[":path"]),
Description: string(info[":description"]),
Title: string(info[":title"]),
}, nil
}
return RouteInfo{}, errors.New("route info not found in cache")
}
func newRouteCache(opts ...RouteCacheOpt) (*routeCache, error) {
s, err := badger.NewBadgerStore(badger.WithSubDir("route_cache"))
if err != nil {
return nil, jerr.Wrap(jerr.ErrFailedToCreateRouteCache, err)
}
cache := &routeCache{
rs: make(map[string]string),
s: s,
}
for _, opt := range opts {
opt(cache)
}
return cache, nil
} }

View File

@ -4,45 +4,89 @@ import (
"context" "context"
"log" "log"
"net/http" "net/http"
"regexp"
"strings"
"time" "time"
jerr "git.markbailey.dev/cerbervs/joist/internal/errors"
"github.com/go-chi/chi/v5" "github.com/go-chi/chi/v5"
) )
type Router struct {
chi.Mux
cache RouteCacher
}
type RouteInfo struct { type RouteInfo struct {
Method string
Name string Name string
Path string Path string
Description string Description string
Title string Title string
} }
func NewRouteInfo(method, path, description, title string) (RouteInfo, error) {
name, err := convertRouteToRouteName(path)
if err != nil {
return RouteInfo{}, err
}
return RouteInfo{
Method: method,
Name: name,
Path: path,
Description: description,
Title: title,
}, nil
}
type routeInfoKey struct{} type routeInfoKey struct{}
type Router struct {
chi.Mux
cache RouteCacher
cacheTTL time.Duration
}
func NewRouter() Router { func NewRouter() Router {
cache, err := NewRouteCache(WithTTL(8 * time.Hour)) ttl := 8 * time.Hour
cache, err := NewRouteCacheService(WithTTL(ttl))
if err != nil { if err != nil {
log.Fatal("failed to create route cache") log.Fatal(jerr.Wrap(err, jerr.ErrRouterNotCreated))
} }
return Router{cache: cache} return Router{cache: cache, cacheTTL: ttl}
} }
// FIX: figure out the right middleware pattern or way to inject route info func (ro *Router) WithRouteInfo(ri RouteInfo, h HandlerFn) http.HandlerFunc {
func WithRouteInfo(ri RouteInfo) func(http.Handler) http.Handler { ro.cache.AddRouteInfo(ri)
return func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { return func(w http.ResponseWriter, r *http.Request) {
ctx := context.WithValue(r.Context(), routeInfoKey{}, ri) ctx := context.WithValue(r.Context(), routeInfoKey{}, ri)
next.ServeHTTP(w, r.WithContext(ctx)) h.ServeHTTP(w, r.WithContext(ctx))
})
} }
} }
// TODO: move to base handler when it's implemented
func GetRouteInfo(r *http.Request) (RouteInfo, bool) { func GetRouteInfo(r *http.Request) (RouteInfo, bool) {
info, ok := r.Context().Value(routeInfoKey{}).(RouteInfo) info, ok := r.Context().Value(routeInfoKey{}).(RouteInfo)
return info, ok return info, ok
} }
func convertRouteToRouteName(route string) (string, error) {
name := "app"
if route == "/" {
return name + ".home", nil
}
route = strings.ReplaceAll(route, "/", ".")
route = strings.ReplaceAll(route, "-", "_")
paramRegex := regexp.MustCompile(`\.{[^}]*}`)
params := paramRegex.FindAllString(route, -1)
route = paramRegex.ReplaceAllString(route, "")
if len(params) > 0 {
route += ".params"
}
name += strings.TrimRight(route, ".")
return name, nil
}